githubnext/chopinPublic

Let's compose rich plans together

[use-effect] Reclassify plan editor wire-reset from Effect to render-time adjustment #66

Mergedgithub-actions[bot]botmerged 3 commits intomainfromrefs/pull/66/head
ConversationFiles changed
1 file changed+5-8
StackedSplit
packages/editor/src/plan-editor.tsx+5 −8

Comments on earlier or unavailable lines

The explanatory comment is a bit misleading around Strict Mode: Strict Mode doesn’t “skip” Effects; in dev it intentionally re-runs mount Effects (and double-invokes render), so wording like “cannot be skipped by Strict Mode’s double-invoked Effects” reads backwards/unclear. Consider rephrasing to focus on the concrete behavior change (avoiding a post-commit Effect-driven reset render) without implying Effects are skipped.

packages/editor/src/plan-editor.tsx:269–272heade6c75e1

Removed the comment entirely in ddf1981.

packages/editor/src/plan-editor.tsx:269–272heade6c75e1