githubnext/chopinPublic

Let's compose rich plans together

Count the replies, not the places they sit in

The petrol pill on a quote was reporting how many spans of prose the
thread is anchored in. That number already had a home: it is what the
jump does, so the button's label says it and nothing is served by
drawing it twice. What the canvas asks for beside a quote is a quoted
span with replies on it — the count that grows while somebody is
waiting on an answer, which is the only one worth acting on.

So Quote takes the two numbers apart. Places still decide whether the
quote is a button and what that button promises; replies take the pill.
The opening comment is not a reply, so a thread nobody has answered
counts nothing and shows nothing, which is what the rest of this
surface already does with a state that is fine.

The pill moves outside the button and carries its own word for a
screen reader, so a drifted thread — which has no jump left to offer
and falls back to a blockquote — still counts its replies out loud.
MAMaggie Appleton authored
3ff44f7Patch
Parentc54367c
3 files changed+56-33
StackedSplit
e2e/sidecar.e2e.ts+6 −1
packages/editor/src/comments.tsx+46 −28
packages/editor/src/count.tsx+4 −4