githubnext/chopinPublic

Let's compose rich plans together

Add rendered design checks to required browser CI #209

MergedMaggieAppletonmerged 3 commits intomainfromrefs/pull/209/head
  1. MA
    MaggieAppleton

    **Goal:** Catch visible changes to Chopin's interface before they reach users, while preserving the appearance choices approved in #208.

    **What we tested:** The required browser CI job opens real examples of Chopin's interface in a fixed Linux Chromium browser. It runs 38 checks across desktop and narrow screens. Those checks compare 32 screenshots with reviewed reference images, exercise menus, dialogs, keyboard focus, scrolling and 200% text, and scan the visible examples for common accessibility problems. The existing system tests cover the running application separately.

    **What we found:** The interface examples match their reviewed images after reconciling this branch with current `main`. The original Delete red, quiet conversation metadata and code colours remain as approved. Known colour-contrast findings are recorded precisely; a new or changed finding fails CI. This is targeted coverage of the examples, not a claim that every screen has been tested or is fully accessible.

    **Validation:** Locally, all 38 Linux browser checks, 1,711 unit tests, TypeScript checks and the design contract pass. [All three required GitHub checks passed on the latest rebased commit](https://github.com/githubnext/chopin/actions/runs/36699868794).

    ### How the checks run

    ![Rendered checks run inside the existing required e2e job](https://github.com/user-attachments/assets/5acf80bb-8fe4-4abc-97db-bc11a25fa7b8)

    ### Approved appearance and tested behavior

    ![Original conversation and code colours, original Delete red, and tested rename error state](https://github.com/user-attachments/assets/815ee734-ec63-4e29-add9-4c5eec05178f)

    [Coverage and review instructions](https://github.com/githubnext/chopin/blob/maggie/design-browser-ci/e2e/design/README.md)

  2. MaggieAppletonreferenced this in Repair core interface readability and keyboard recovery #208last month on GitHub

  3. MaggieAppletonbase-ref-changedlast month on GitHub

  4. MaggieAppletonadded-to-stacklast month on GitHub

  5. MaggieAppletonbase-ref-force-pushedlast month on GitHub

  6. MaggieAppletonautomatic-base-change-succeededlast month on GitHub

  7. MaggieAppletonhead-ref-force-pushed 5c5cc48cccfflast month on GitHub

  8. MaggieAppletonhead-ref-force-pushed 0f8d89b0e4b7last month on GitHub

  9. MAAdd rendered design checks to required browser CI4ef7628
  10. MARemove temporary audit reports and redundant browser probes53fea65
  11. MAStabilize design screenshots after main rebaseb92bfc1

  12. MaggieAppletonhead-ref-force-pushed b92bfc1fcfeelast month on GitHub

  13. MaggieAppletonmerged bedab2d6ea8flast month on GitHub

  14. MaggieAppletonclosedlast month on GitHub

  15. MaggieAppletonhead-ref-deletedlast month on GitHub