githubnext/chopinPublic

Let's compose rich plans together

Require evidence before the Effect review bot opens PRs #228

MergedMaggieAppletonmerged 4 commits intomainfromrefs/pull/228/head
  1. MA

    The Effect review bot proposed PR #222 solely to remove a dependency suppression, without establishing a reachable bug. Require caller and lifecycle evidence, a concrete failure or measurable unnecessary work, preserved setup/cleanup ownership, and verification of the actual claim. Missing required checks now mean no PR; zero findings is explicitly successful.

    Regenerated the workflow lock file. Schedule, permissions, and the five-PR limit are unchanged.

    Also stabilizes the PostgreSQL job-lock lease regression: handle the expected rejection immediately, observe the actual lock wait, and wait for expiry using PostgreSQL’s clock.

    Validation: workflow compilation; `bun run ci`, types, build, 1,729 unit tests, and all 59 PostgreSQL tests pass. The repaired lease test also passes 10 consecutive runs.

    ### Acceptance gates

    ![The Effect review bot must trace the lifecycle, justify the change, and verify its claim before opening a draft PR.](https://github.com/user-attachments/assets/3372c42f-da66-4d5e-b002-8a66ccf3fe71)

  2. MaggieAppletonmerged 379402dcbf08last month on GitHub

  3. MaggieAppletonclosedlast month on GitHub

  4. MaggieAppletonhead-ref-deletedlast month on GitHub