githubnext/chopinPublic

Let's compose rich plans together

Refine completed decision cards #302

MergedMaggieAppletonmerged 2 commits intomainfromrefs/pull/302/head
  1. MA
    MaggieAppleton

    ## Integration and validation

    Resolved cards retain every answer option, show the selected answer and provenance, and gate edit actions by permission. Preserved current inline-code rendering and authoritative decision state while resolving the question-view conflict.

    Formatting/lint/design checks, types, 150 focused tests and all 10 decision-card browser tests pass locally. Required CI will be rerun on the final main rebase before merge.

    <details> <summary>Original proposal and screenshots</summary>

    ## What changed

    Answered decisions now use the same card language as decisions awaiting an answer. The original choices remain visible, with the chosen answer highlighted. The question keeps its heading and decision icon, and the answerer and time sit quietly below the choices. Reopen and Discard remain available to people who can use them.

    This makes a finished decision easy to recognize and scan, while keeping its past choices and context. The rows are read-only, so they do not suggest that clicking them will change the answer.

    ## Before and after

    ![Before and after the resolved decision card redesign](https://github.com/user-attachments/assets/9953cf3c-9c00-48fd-8cf6-0b1da61024e4)

    ## Verification

    - 12 focused unit checks, including multiple answers, older saved formats, missing answer fallback, and read-only markup. - 10 Chromium browser checks covering answered cards, navigation, permissions, actions, and a compact viewport. - Type checks, production build, formatter, and local CI checks passed. - Independently reviewed for behavior, accessibility, responsive layout, and consistency with the open card; no findings.

    The discarded state and stored decision data are unchanged. The design and implementation notes are in `docs/resolved-decision-card-design.md` and `docs/resolved-decision-card-plan.md`.

    </details>

  2. lavaman131referenced this in [Design] Rebuild the workflow run card with assistant-ui Elements #307last month on GitHub

  3. lavaman131referenced this in [Design] Replace the composer @ mention picker with assistant-ui mentions #308last month on GitHub

  4. lavaman131referenced this in [Design] Conversation controls with assistant-ui Elements: message queue, stopped run, error state #309last month on GitHub

  5. lavaman131referenced this in [Design] Research and references with assistant-ui Elements #310last month on GitHub

  6. lavaman131referenced this in [Design] Decisions display with assistant-ui Elements (option list, question flow) #311last month on GitHub

  7. lavaman131referenced afb151ae367alast month on GitHub

  8. lavaman131referenced 168b4551040flast month on GitHub

  9. MaggieAppletonhead-ref-force-pushed 83c103c20c2elast month on GitHub

  10. MaggieAppletonhead-ref-force-pushed bcb0fb35eec6last month on GitHub

  11. MA
    MaggieAppleton
    Author

    I rechecked the latest failed `ci` run on this head. `container` and `e2e` pass; the only failure is in `bun test`, and the failing assertion is `being sent somewhere > starts the clock again each time it is asked` in [packages/editor/src/marks.test.ts], where the merge run expected `[points("c2")]` and received `[]`. That file is outside this PR diff, so I did not push a `[ci-fix]` commit onto the branch. This looks like a merge-vs-main failure on the synthetic PR merge commit rather than a defect introduced by head `bcb0fb35eec68ad4b1702f100cc7c04bb8f242ed`. Next human action: let the rebase workflow refresh the branch onto current `main`, or investigate/fix the regression on `main` if the same marks test is failing there too.

    > Generated by [PR CI fixer](https://github.com/githubnext/chopin/actions/runs/37618971100) · gpt54 · 81 AIC · ⌖ 4.53 AIC · ⊞ 15.1K · [◷](https://github.com/search?q=repo%3Agithubnext%2Fchopin+%22gh-aw-workflow-call-id%3A+githubnext%2Fchopin%2Fpr-ci-fix%22&type=issues)

    <!-- gh-aw-agentic-workflow: PR CI fixer, engine: codex, model: gpt-5.4, id: 37618971100, workflow_id: pr-ci-fix, run: https://github.com/githubnext/chopin/actions/runs/37618971100 --> <!-- gh-aw-workflow-call-id: githubnext/chopin/pr-ci-fix -->

  12. MaggieAppletonhead-ref-force-pushed 388ae001afcdlast month on GitHub

  13. MaggieAppletonhead-ref-force-pushed 5cf9526c5c12last month on GitHub

  14. MaggieAppletonhead-ref-force-pushed 662f92f58f68last month on GitHub

  15. MaggieAppletonhead-ref-force-pushed fdb5f6dedeeclast month on GitHub

  16. MaggieAppletonreferenced this in Quiet accepted-comment row in the document #357last month on GitHub

  17. MaggieAppletonreferenced this in Show decision evidence as a summary row with objections #361last month on GitHub

  18. MaggieAppletonreferenced this in Show each decision's relationship to the document #367last month on GitHub

  19. MaggieAppletonreferenced this in Mark the Document tab when the Planner writes out of view #372last month on GitHub

  20. MaggieAppletonauto-rebase-enabledlast month on GitHub

  21. MADesign resolved decision card presentation360b2f5
  22. MARefine resolved decision cardsac1b8ab

  23. MaggieAppletonhead-ref-force-pushed ac1b8aba6d68last month on GitHub

  24. MaggieAppletonmerged 43f2c237b3a3last month on GitHub

  25. MaggieAppletonclosedlast month on GitHub

  26. MaggieAppletonhead-ref-deletedlast month on GitHub