githubnext/chopinPublic

Let's compose rich plans together

Make pin lifetime tests deterministic on busy CI runners #329

MergedMaggieAppletonmerged 1 commit intomainfromrefs/pull/329/head
  1. MA

    The pin lifetime tests slept for 15 ms and assumed a 30 ms timer had not expired. A busy CI runner can resume late and fail these tests even when pin behavior is correct.

    Use a synchronous clock in these two tests. Verify a renewed pin survives the original deadline and expires exactly at its new deadline; restore timer mocks after each test. Production code is unchanged.

    Validation: 20 repeated test-file runs, all 458 editor tests, editor type checks, and repository formatting pass. Removing cancellation or expiry makes the tests fail as expected.

    ![A controlled clock checks the original and renewed pin expiry deadlines](https://github.com/user-attachments/assets/2c62da6b-fab5-41f4-94e4-f1357ad034bc)

  2. MaggieAppletonhead-ref-force-pushed d7dfd8c2cf1dlast month on GitHub

  3. MaggieAppletonmerged 02318fbb5738last month on GitHub

  4. MaggieAppletonclosedlast month on GitHub

  5. MaggieAppletonhead-ref-deletedlast month on GitHub