githubnext/chopinPublic

Let's compose rich plans together

Keep the settled decision icon full size when its text wraps #393

ClosedMaggieAppletonclosed 2 commits intomainfromrefs/pull/393/head
  1. MA
    MaggieAppleton

    ## Why On a settled decision line ("Decided: <long option> 路 @name"), the decision icon is an SVG flex item that shrank when the text wrapped. It rendered at 9px on desktop and about 6px on phone, instead of 14px.

    ## What changed - `SettledLine` icon: `shrink-0 self-start`, with a top margin of `(1lh - 14px) / 2` so it sits on the first line's centre however many lines wrap. The row's own classes are untouched, so #367 and #376 still merge cleanly. - Chat collapsed decision prompt icon: `shrink-0` (same pattern; the text there truncates, so this is defensive). - Scanned the other decision, research and Chat activity rows. They already use `shrink-0` or a fixed-size wrapper with `items-start`. - New Playwright test in `e2e/sidecar-card-states.e2e.ts`: icon box (width, height, offset from the line top) is identical for a one-line and a wrapped settled line.

    ## Screenshots Before (top) and after (bottom), desktop and phone:

    ![desktop](https://github.com/user-attachments/assets/d548fb1f-92b8-4f0f-b143-53e85a72ffb9)

    ![phone](https://github.com/user-attachments/assets/2b67629b-45b7-4f1b-9d07-9b676b0c13a2)

    ## Testing - `bun run types`: pass. `bun test packages/editor`: 536 pass. - `bun run ci`: dprint and oxlint pass; design-contract fails only on the pinned hash (below). - Local e2e is suspended; relying on CI browser-integration for the new test.

    ## Needs a design-contract review `packages/editor/src/widgets/questionnaire.tsx` is pinned in `scripts/design-contract/exceptions/dynamic-editor.json` (source hash `15e75053...`). New hash: `6ee3b4952dc534f10ccc69fdb715a023275a5770862893f6220d71230909ff83`. Safe because the change adds only static classes and a data attribute to an existing icon; no dynamic style or class logic.

    馃 Generated with [Claude Code](https://claude.com/claude-code)

  2. C5MAKeep the settled decision icon full size when its text wraps0a6928e

  3. namementionedlast month on GitHub

  4. namesubscribedlast month on GitHub

  5. MaggieAppletonreferenced this in Keep every icon at its declared size beside wrapping text #398last month on GitHub

  6. MARenew reviewed settled icon hashf18972e

  7. MaggieAppletonclosedlast month on GitHub

  8. coolify-githubnext-app[bot]bot

    The preview deployment for **chopin** failed. 馃敶

    [Open Build Logs](https://next-appserver.tail49836a.ts.net/project/l9buznc9ua1if0vflxrjwajs/environment/lxqsvczv19eopxk29vfb46mj/application/hb85gdd9mwqqlfwcteflvpbj/deployment/9030tjjnjx2dzoeayz2ghrux) | [Open Application Logs](https://next-appserver.tail49836a.ts.net/project/l9buznc9ua1if0vflxrjwajs/environment/lxqsvczv19eopxk29vfb46mj/application/hb85gdd9mwqqlfwcteflvpbj/logs)

    Last updated at: 2026-10-08 08:57:32 CET