lukeed/clsxPublic

A tiny (239B) utility for constructing `className` strings conditionally.

Check `pop` instead of `push` #16

Closedghostclosed 2 commits intomasterfromrefs/pull/16/head
  1. GH

    I cut a little bytes :) I used `pop` instead of `push`.

    And one small question... `!!` operator is needed? When we use this operator, JS can performs more faster?

  2. lukeedmentioned6 years ago on GitHub

  3. lukeedsubscribed6 years ago on GitHub

  4. LU

    Hey, it very much is. This just isn't very high priority since it only shaves 1 byte 😄

    Please revert the `!!` omission – that's needed to prevent the coalesce to boolean. It has measurable impact in V8

    I won't publish a new release for 1B savings, lol, but I'll definitely merge this in the next time `clsx` needs attention. I generally don't like to keep `master` dirty

    Thanks!

  5. 태재Revert `!!`0e07b08
  6. Unknown GitHub userrenamed Cut a little bytes to Check `pop` instead of `push`6 years ago on GitHub

  7. GH
    Author

    Is performing two `!` operators cheaper than measuring about non-boolean type? It's really interesting! Thank you for teaching it :)

    Now I revert `!!`

  8. Unknown GitHub userclosed6 years ago on GitHub